Repository navigation
feat: add indicator part to new fields - #2312
Merged
Merged
Conversation
web-padawan
force-pushed
the
feat/indicator-part
branch
from
August 10, 2021 07:54
4b63848 to
43b6c59
Compare
vursen
reviewed
Aug 10, 2021
hdamr
reviewed
Aug 10, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
Contributor
|
@hdamr May I ask you to provide any information that could help to reproduce the issue you are facing? Unfortunately, I wasn't able to reproduce the issue you reported in neither of the browsers (Chrome, Safari, Firefox), the label is always announced in my case. I used the following snippet: <vaadin-text-field label="Label" required></vaadin-text-field>
<script type="module">
import { TextField } from '@vaadin/text-field';
customElements.define('vaadin-text-field', TextField);
</script> |
Contributor
|
@vursen per discussion I had with Serhii, This is the intended correct behaviour. |
vursen
approved these changes
Aug 12, 2021
vursen
added a commit
that referenced
this pull request
Sep 15, 2026
## Description Lumo reserves `1em` of end padding on every field label for the required indicator. The padding comes from vaadin/vaadin-lumo-styles#92 (merged here in #2312) as a workaround for a fading indicator that jumped when `required` was toggled. The indicator no longer has a transition, so the padding serves no purpose on non-required fields, and in the `label-aside` variant it adds to the gap between the label and the input. This change applies the padding only under `:host([required])`, as the base styles do. No Lumo screenshot changed, since the label only shrinks by the padding, which is not visible unless the label is wider than the field. Related to #12729 Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.









Description
indicatorpartpaddingon the label part.See Fix issue #83 required field: indicator jumps when setting required to false vaadin-lumo-styles#92
Fixes #2301
Fixes #1634
Type of change