Skip to content

fix: add reveal button focus ring styles - #2345

Merged
web-padawan merged 2 commits into
masterfrom
fix/password-focus-ring
Aug 17, 2021
Merged

web-padawan merged 2 commits into
masterfrom
fix/password-focus-ring

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

Added the styles for reveal button focused state.

Fixes #2326

Note

I did not find an example of a focusable icon in the Material Design guidelines as there the eye icon does not get focus:
https://material-components.github.io/material-components-web-catalog/#/component/text-field

So the ripple CSS is copied from vaadin-radio-button and adapted to have :hover, :focus and :active states.

@web-padawan web-padawan added the a11y Accessibility issue label Aug 16, 2021
@web-padawan
web-padawan requested a review from jouni August 16, 2021 11:13
@fhdhsni
fhdhsni self-requested a review August 17, 2021 05:25
Co-authored-by: Jouni Koivuviita <jouni@vaadin.com>
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan
web-padawan merged commit 63a730e into master Aug 17, 2021
@web-padawan
web-padawan deleted the fix/password-focus-ring branch August 17, 2021 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a11y Accessibility issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[password-field] Add focus-ring styles for reveal button

3 participants