Skip to content

refactor!: move vaadin-radio-button to radio-group - #2420

Merged
web-padawan merged 2 commits into
masterfrom
feat/move-radio-button-1
Aug 31, 2021
Merged

web-padawan merged 2 commits into
masterfrom
feat/move-radio-button-1

Conversation

@vursen

@vursen vursen commented Aug 30, 2021 •

Copy link
Copy Markdown
Contributor

Description

This PR moves @vaadin/vaadin-radio-button to @vaadin/radio-group.

The PR follows the instruction given in #1992 (comment).

  • 1. Create a PR where rename the old package to the new one.

Part of #1992.

Type of change

  • Breaking change

Checklist

  • I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@vursen
vursen requested a review from web-padawan August 30, 2021 14:33
@vursen
vursen force-pushed the feat/move-radio-button-1 branch from 2c85fbb to 968ab57 Compare August 30, 2021 14:34
@vursen vursen changed the title refactor!: move vaadin-radio-button to radio-button refactor!: move vaadin-radio-button to radio-button (WIP) Aug 30, 2021
@vursen vursen changed the title refactor!: move vaadin-radio-button to radio-button (WIP) refactor!: split vaadin-radio-button into radio-button, radio-group (WIP) Aug 30, 2021
@vursen
vursen force-pushed the feat/move-radio-button-1 branch 2 times, most recently from e0231db to ce98004 Compare August 31, 2021 09:39
@vursen vursen changed the title refactor!: split vaadin-radio-button into radio-button, radio-group (WIP) refactor!: move vaadin-radio-button to radio-group Aug 31, 2021
@vursen
vursen force-pushed the feat/move-radio-button-1 branch 2 times, most recently from 8260429 to db8d38b Compare August 31, 2021 10:06
@vursen
vursen force-pushed the feat/move-radio-button-1 branch from db8d38b to 8a15a75 Compare August 31, 2021 10:12
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 14 Code Smells

No Coverage information No Coverage information
2.4% 2.4% Duplication

@web-padawan
web-padawan merged commit 6caf408 into master Aug 31, 2021
@web-padawan
web-padawan deleted the feat/move-radio-button-1 branch August 31, 2021 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants