Skip to content

feat: update to latest Highcharts - #2433

Merged
alvarezguille merged 3 commits into
masterfrom
feat-update-highcharts
Sep 9, 2021
Merged

alvarezguille merged 3 commits into
masterfrom
feat-update-highcharts

Conversation

@alvarezguille

Copy link
Copy Markdown
Contributor

No description provided.

@alvarezguille
alvarezguille marked this pull request as ready for review September 8, 2021 12:42
@sonarqubecloud

sonarqubecloud Bot commented Sep 8, 2021

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sissbruecker sissbruecker left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look reasonable. Did manual testing with the demos from https://charts.demo.vaadin.com, and could not find any issues.

@alvarezguille
alvarezguille merged commit 33a9d40 into master Sep 9, 2021
@alvarezguille
alvarezguille deleted the feat-update-highcharts branch September 9, 2021 08:40
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with platform 22.0.0.alpha4 and is also targeting the upcoming stable 22.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants