Repository navigation
fix: fire click on Enter and Space, but not when disabled - #2438
Conversation
24d1c9d to
9487735
Compare
9487735 to
b359935
Compare
b359935 to
c80cdaf
Compare
web-padawan
left a comment
There was a problem hiding this comment.
Looks like updating drawer toggle caused its tests to fail:
❌ drawer-toggle > click event > disabled > should not fire "drawer-toggle-click" event on click when disabled
AssertionError: expected true to be false
+ expected - actual
-true
+false
I would say this should be fixed by adding this missing logic:
This logic is present in DelegatesFocusMixin but it also needs to be added to Button.
@web-padawan Added a similar logic to |
|
Kudos, SonarCloud Quality Gate passed!
|
web-padawan
left a comment
There was a problem hiding this comment.
Confirmed that GridDelegateFocusToComponentIT.focusButton passes locally with the fix.
|
This ticket/PR has been released with platform 22.0.0.alpha3 and is also targeting the upcoming stable 22.0.0 version. |








Description
The PR fixes the regression that occurred after we released the new
@vaadin/buttonpackage:Note,
<vaadin-drawer-toggle>now fires thedrawer-toggle-clickevent onkeydownrather thankeyupthe way it was before. This might be considered as a breaking-change.Fixes #2437
WARNING: Please, do not merge this PR before #2432 is merged.(merged)Specs
Type of change
Checklist