Skip to content

fix: set disabled on lazily added focusElement - #2511

Merged
web-padawan merged 2 commits into
masterfrom
fix/select-disabled
Sep 13, 2021
Merged

web-padawan merged 2 commits into
masterfrom
fix/select-disabled

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

The original problem happens because of how we apply mixins: unlike other fields, in case of vaadin-select we initialize focusElement in the component itself, and not in a deeply nested mixins like InputSlotMixin.

But the root cause is the fact that disabled property is not set on the lazily added focusElement. This PR fixes it.

Fixes #2472

Type of change

  • Bugfix

@web-padawan web-padawan added the a11y Accessibility issue label Sep 13, 2021
@web-padawan
web-padawan requested a review from vursen September 13, 2021 06:40
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with platform 22.0.0.alpha4 and is also targeting the upcoming stable 22.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[select] It is possible to focus disabled select using Tab

3 participants