Repository navigation
fix: set disabled on lazily added focusElement - #2511
Merged
Merged
Conversation
vursen
reviewed
Sep 13, 2021
vursen
approved these changes
Sep 13, 2021
web-padawan
force-pushed
the
fix/select-disabled
branch
from
September 13, 2021 10:21
2c477d0 to
4591b70
Compare
web-padawan
force-pushed
the
fix/select-disabled
branch
from
September 13, 2021 10:52
4591b70 to
3ee5e10
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Collaborator
|
This ticket/PR has been released with platform 22.0.0.alpha4 and is also targeting the upcoming stable 22.0.0 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
The original problem happens because of how we apply mixins: unlike other fields, in case of
vaadin-selectwe initializefocusElementin the component itself, and not in a deeply nested mixins likeInputSlotMixin.But the root cause is the fact that
disabledproperty is not set on the lazily addedfocusElement. This PR fixes it.Fixes #2472
Type of change