Skip to content

refactor!: change ThemableMixin to no longer depend on Polymer - #2594

Merged
web-padawan merged 27 commits into
masterfrom
refactor-themable-mixin
Sep 29, 2021
Merged

web-padawan merged 27 commits into
masterfrom
refactor-themable-mixin

Conversation

@tomivirkki

@tomivirkki tomivirkki commented Sep 21, 2021 •

Copy link
Copy Markdown
Member

Fixes #2473

Refactor vaadin-themable-mixin not to depend on Polymer (<dom-module>) by default. <dom-module> styling support can be restored by importing the adapter shipped in an external package.

@tomivirkki tomivirkki added the no-polymer Removing Polymer from Vaadin public APIs label Sep 21, 2021
@tomivirkki
tomivirkki marked this pull request as draft September 21, 2021 11:07
@tomivirkki tomivirkki changed the title refactor!: refactor themable mixin not to depend on Polymer refactor!: refactor themable mixin not to use dom-module Sep 21, 2021
@tomivirkki
tomivirkki force-pushed the refactor-themable-mixin branch from 92e7d26 to d9c291e Compare September 21, 2021 15:11
@tomivirkki
tomivirkki force-pushed the refactor-themable-mixin branch 10 times, most recently from 9da454d to f109363 Compare September 24, 2021 09:27
@tomivirkki
tomivirkki force-pushed the refactor-themable-mixin branch from f109363 to b603460 Compare September 24, 2021 09:44
@tomivirkki
tomivirkki marked this pull request as ready for review September 24, 2021 10:57
# Conflicts:
#	packages/vaadin-themable-mixin/register-styles.js
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan web-padawan changed the title refactor!: refactor themable mixin not to use dom-module refactor!: change ThemableMixin to no longer depend on Polymer Sep 29, 2021
@web-padawan
web-padawan merged commit 612f7c6 into master Sep 29, 2021
@web-padawan
web-padawan deleted the refactor-themable-mixin branch September 29, 2021 13:08
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with platform 22.0.0.alpha7 and is also targeting the upcoming stable 22.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make dom-module based theming support optional

3 participants