Repository navigation
refactor!: change ThemableMixin to no longer depend on Polymer - #2594
Merged
Merged
Conversation
tomivirkki
marked this pull request as draft
September 21, 2021 11:07
web-padawan
reviewed
Sep 21, 2021
tomivirkki
force-pushed
the
refactor-themable-mixin
branch
from
September 21, 2021 15:11
92e7d26 to
d9c291e
Compare
web-padawan
reviewed
Sep 21, 2021
tomivirkki
force-pushed
the
refactor-themable-mixin
branch
10 times, most recently
from
September 24, 2021 09:27
9da454d to
f109363
Compare
tomivirkki
force-pushed
the
refactor-themable-mixin
branch
from
September 24, 2021 09:44
f109363 to
b603460
Compare
tomivirkki
marked this pull request as ready for review
September 24, 2021 10:57
# Conflicts: # packages/vaadin-themable-mixin/register-styles.js
web-padawan
reviewed
Sep 29, 2021
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
web-padawan
requested changes
Sep 29, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
web-padawan
approved these changes
Sep 29, 2021
Collaborator
|
This ticket/PR has been released with platform 22.0.0.alpha7 and is also targeting the upcoming stable 22.0.0 version. |
This was referenced Nov 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Fixes #2473
Refactor
vaadin-themable-mixinnot to depend on Polymer (<dom-module>) by default.<dom-module>styling support can be restored by importing the adapter shipped in an external package.