Repository navigation
feat: use Lumo icons in number-field controls - #2595
Conversation
ce1d62a to
756a727
Compare
|
Updated visual tests and marked this as |
|
Oh, I’d actually forgotten we have the plus and minus icons in Lumo. Are they used somewhere else at the moment? I think this is a welcome enhancement. I wouldn’t call it a bug fix. It might cause some issues in custom themes, if someone has adjusted the font family, size, or weight of those buttons, to make the icons fit better with their theme. |
|
Thanks. I will update the remaining screenshots and approve the PR. We can include it to Vaadin 22 and backport to 14.8 if necessary. |
756a727 to
44d25f9
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
This ticket/PR has been released with platform 22.0.0.alpha7 and is also targeting the upcoming stable 22.0.0 version. |








Description
Lumo icons contain "plus" and "minus" icons but those haven't been previously used in Lumo theme of Number Field.
The icons for non-styled component are defined as "+" and "-" characters.
See: https://github.com/vaadin/web-components/blob/master/packages/number-field/src/vaadin-number-field.js#L77-L83
The visual difference is very small, but this helps in changing the icons from Lumo icons to other set.
Before / After

Type of change
Checklist