Skip to content

feat: use Lumo icons in number-field controls - #2595

Merged
web-padawan merged 2 commits into
masterfrom
fix/icon-variables
Sep 21, 2021
Merged

web-padawan merged 2 commits into
masterfrom
fix/icon-variables

Conversation

@juuso-vaadin

Copy link
Copy Markdown
Contributor

Description

Lumo icons contain "plus" and "minus" icons but those haven't been previously used in Lumo theme of Number Field.

The icons for non-styled component are defined as "+" and "-" characters.
See: https://github.com/vaadin/web-components/blob/master/packages/number-field/src/vaadin-number-field.js#L77-L83
The visual difference is very small, but this helps in changing the icons from Lumo icons to other set.

Before / After
image

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@juuso-vaadin
juuso-vaadin requested a review from jouni September 21, 2021 12:10
@web-padawan web-padawan changed the title Fix: Use Lumo icons in Number Field increase and decrease buttons refactor: use Lumo icons in number-field increase and decrease buttons Sep 21, 2021
@web-padawan web-padawan changed the title refactor: use Lumo icons in number-field increase and decrease buttons feat: use Lumo icons in number-field increase and decrease buttons Sep 21, 2021
@web-padawan

Copy link
Copy Markdown
Member

Updated visual tests and marked this as feat: because to me it looks more like a new feature than a bug fix.
@jouni Should we consider this change a bug fix to make it possible to backport to 21.0, WDYT?

@web-padawan web-padawan changed the title feat: use Lumo icons in number-field increase and decrease buttons feat: use Lumo icons in number-field controls Sep 21, 2021
@jouni

jouni commented Sep 21, 2021

Copy link
Copy Markdown
Member

Oh, I’d actually forgotten we have the plus and minus icons in Lumo. Are they used somewhere else at the moment?

I think this is a welcome enhancement. I wouldn’t call it a bug fix. It might cause some issues in custom themes, if someone has adjusted the font family, size, or weight of those buttons, to make the icons fit better with their theme.

@web-padawan

Copy link
Copy Markdown
Member

Thanks. I will update the remaining screenshots and approve the PR. We can include it to Vaadin 22 and backport to 14.8 if necessary.

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with platform 22.0.0.alpha7 and is also targeting the upcoming stable 22.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants