Skip to content

fix: use text color property for inactive tabs - #2630

Merged
web-padawan merged 2 commits into
masterfrom
fix/lumo-inactive-tab-contrast
Sep 24, 2021
Merged

web-padawan merged 2 commits into
masterfrom
fix/lumo-inactive-tab-contrast

Conversation

@jouni

@jouni jouni commented Sep 24, 2021 •

Copy link
Copy Markdown
Member

Description

Use a text color property instead of a contrast color property, to better guarantee that the text always has sufficient contrast with the background.

Fixes #662

Related to #119 (depends on #2626)

Type of change

  • Bugfix

Checklist

  • I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@web-padawan
web-padawan force-pushed the fix/lumo-inactive-tab-contrast branch from c24a873 to 6cda115 Compare September 24, 2021 16:55
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan web-padawan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Updated the reference screenshots even though the tests didn't fail 🤔

@web-padawan
web-padawan merged commit 7167236 into master Sep 24, 2021
@web-padawan
web-padawan deleted the fix/lumo-inactive-tab-contrast branch September 24, 2021 17:01
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with platform 22.0.0.alpha7 and is also targeting the upcoming stable 22.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[tabs] Use a text color property for inactive tabs

3 participants