Repository navigation
refactor!: make radio-group use new mixins - #2641
Conversation
cca2d8d to
90dd10b
Compare
|
|
||
| var nextButton = element.nextElementSibling || this.firstElementChild; | ||
| __selectIncRadioButton(index, step) { | ||
| const newIndex = (this.__radioButtons.length + index + step) % this.__radioButtons.length; |
There was a problem hiding this comment.
The previous approach with nextElementSibling/ prevElementSibling was based on an assumption that the group contains only radio buttons as children. Now, there are also the slotted helper, label, and error message, so I had to come up with a different solution.
9cf31e7 to
4d337ed
Compare
|
For some reason, it's sometimes hard to get a radio selected radio-issue.mp4 |
It seems that the The previous implementation was based on handling the The current implementation is based on handling the I wonder what would be the right work-around here.
|
|
... although, the radio-button click area issues don't seem to be related to this PR and might be considered more as regressions of the radio-button, not the radio-group. |
cb34d34 to
1ecc263
Compare
Reported the issue regarding the clickable area of the radio-button: #2690 |
|
Reported the issue regarding the clickable area of the checkbox as it has the same problem: #2693 |
729320e to
76ffd85
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
This ticket/PR has been released with platform 22.0.0.alpha7 and is also targeting the upcoming stable 22.0.0 version. |








Description
The PR re-implements
<vaadin-radio-group>to use the new mixins taking the radio-group a11y prototype as a starting point.<vaadin-radio-group>to use the new mixins.<vaadin-radio-button>unit tests pass.<vaadin-overlayunit tests pass.Type of change
Checklist