Skip to content

fix: increase input placeholder text color contrast (Lumo) - #2715

Merged
web-padawan merged 2 commits into
masterfrom
fix/input-placeholder-text-contrast
Oct 1, 2021
Merged

web-padawan merged 2 commits into
masterfrom
fix/input-placeholder-text-contrast

Conversation

@jouni

@jouni jouni commented Oct 1, 2021

Copy link
Copy Markdown
Member

Related to #119 (fixes some of the issues listed there)

The color contrast is above 4.5:1 for both normal, hovered, invalid, and invalid hovered states.

I’m not sure why opacity changes were previously animated. I don't think that is necessary, so I removed that as well.

@web-padawan web-padawan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Not sure why the visual tests passed, maybe the diff is too small.

@jouni

jouni commented Oct 1, 2021

Copy link
Copy Markdown
Member Author

Yeah, that’s interesting for sure. It should be fairly noticeable. I need to double-check it.

@jouni

jouni commented Oct 1, 2021 •

Copy link
Copy Markdown
Member Author

Here’s a visual comparison (after vs before):

Screen Shot 2021-10-01 at 16 23 49

@web-padawan

Copy link
Copy Markdown
Member

I will try to update all the screenshots for Lumo and commit updated screenshots to the PR, if any.
Sometimes the tests pass, yet the new screenshots are created with yarn update:lumo 🤷‍♂️

@web-padawan
web-padawan force-pushed the fix/input-placeholder-text-contrast branch from 879489e to 600ac07 Compare October 1, 2021 13:42
@sonarqubecloud

sonarqubecloud Bot commented Oct 1, 2021

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with platform 22.0.0.alpha7 and is also targeting the upcoming stable 22.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants