Repository navigation
fix: increase input placeholder text color contrast (Lumo) - #2715
Merged
Merged
Conversation
web-padawan
approved these changes
Oct 1, 2021
web-padawan
left a comment
Member
There was a problem hiding this comment.
LGTM. Not sure why the visual tests passed, maybe the diff is too small.
Member
Author
|
Yeah, that’s interesting for sure. It should be fairly noticeable. I need to double-check it. |
Member
Author
Member
|
I will try to update all the screenshots for Lumo and commit updated screenshots to the PR, if any. |
web-padawan
force-pushed
the
fix/input-placeholder-text-contrast
branch
from
October 1, 2021 13:42
879489e to
600ac07
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Collaborator
|
This ticket/PR has been released with platform 22.0.0.alpha7 and is also targeting the upcoming stable 22.0.0 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.









Related to #119 (fixes some of the issues listed there)
The color contrast is above 4.5:1 for both normal, hovered, invalid, and invalid hovered states.
I’m not sure why opacity changes were previously animated. I don't think that is necessary, so I removed that as well.