Repository navigation
feat: improve accessibility based on ARIA 1.2 - #2745
Conversation
| el.setAttribute('theme', this.theme); | ||
| } else { | ||
| el.removeAttribute('theme'); | ||
| } |
There was a problem hiding this comment.
Since aria-setsize was added and virtual scrolling is used, el.setAttribute('aria-posinset', index); also needs to be applied so that the announced index is correct also on the items at the end of the set.
There was a problem hiding this comment.
Hmm...even with aria-posinset there seems to be some oddities with announcing the proper index
There was a problem hiding this comment.
For some reason, the first item is announced as "1 of 200" (1-based index) but the last item announces as "199 of 200" (0-based index)
There was a problem hiding this comment.
Submitted #2747 to investigate if we can fix this later.
tomivirkki
left a comment
There was a problem hiding this comment.
Other than #2745 (comment), lgtm
b61ba18 to
bfeb73f
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
This ticket/PR has been released with platform 22.0.0.alpha7 and is also targeting the upcoming stable 22.0.0 version. |








Description
Fixes #2483
Fixes #1338
Fixes #1341
Fixes #1350 (as we remove the timeout)
Type of change