Skip to content

feat: improve accessibility based on ARIA 1.2 - #2745

Merged
web-padawan merged 7 commits into
masterfrom
fix/combo-box-aria
Oct 5, 2021
Merged

web-padawan merged 7 commits into
masterfrom
fix/combo-box-aria

Conversation

@web-padawan

@web-padawan web-padawan commented Oct 5, 2021 •

Copy link
Copy Markdown
Member

Description

Fixes #2483
Fixes #1338
Fixes #1341
Fixes #1350 (as we remove the timeout)

Type of change

  • Feature

@web-padawan web-padawan added the a11y Accessibility issue label Oct 5, 2021
@web-padawan
web-padawan requested a review from tomivirkki October 5, 2021 11:25
el.setAttribute('theme', this.theme);
} else {
el.removeAttribute('theme');
}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since aria-setsize was added and virtual scrolling is used, el.setAttribute('aria-posinset', index); also needs to be applied so that the announced index is correct also on the items at the end of the set.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm...even with aria-posinset there seems to be some oddities with announcing the proper index

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, the first item is announced as "1 of 200" (1-based index) but the last item announces as "199 of 200" (0-based index)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Submitted #2747 to investigate if we can fix this later.

@tomivirkki tomivirkki left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than #2745 (comment), lgtm

@web-padawan

Copy link
Copy Markdown
Member Author

Reported #2748 and #2749 to investigate remaining issues. These aren't blockers as the behavior in VoiceOver is not any worse after this PR is merged. On the positive side, other issues like #1338 and #1341 seem to be fixed by this PR.

@sonarqubecloud

sonarqubecloud Bot commented Oct 5, 2021

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with platform 22.0.0.alpha7 and is also targeting the upcoming stable 22.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

3 participants