Skip to content

fix!: remove label part and enhance clickable area - #2773

Merged
web-padawan merged 1 commit into
masterfrom
regression/radio-button/clickable-area
Oct 6, 2021
Merged

web-padawan merged 1 commit into
masterfrom
regression/radio-button/clickable-area

Conversation

@vursen

@vursen vursen commented Oct 6, 2021

Copy link
Copy Markdown
Contributor

Description

The PR enhances the radio-button's clickable area so that it becomes clickable over the whole area.

  • Removed the label part (proposal).
  • Set padding on the slotted <label> element.
  • Stretched the input element over the checkbox part including its margins.

Fixes #2690

Type of change

  • Breaking change

Checklist

  • I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@vursen
vursen requested a review from web-padawan October 6, 2021 09:58
@sonarqubecloud

sonarqubecloud Bot commented Oct 6, 2021

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with platform 22.0.0.alpha7 and is also targeting the upcoming stable 22.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[radio-button] Regression: the radio-button is not clickable over the whole area

3 participants