Skip to content

refactor!: move ControlStateMixin to field-base package - #2789

Merged
web-padawan merged 9 commits into
masterfrom
refactor/shadow-focus-mixin
Oct 7, 2021
Merged

web-padawan merged 9 commits into
masterfrom
refactor/shadow-focus-mixin

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

  1. Renamed ControlStateMixin to ShadowFocusMixin to better reflect its purpose and moved it to field-base,
  2. Changed implementation to use TabindexMixin and DelegateFocusMixin which resulted in huge cleanup,
  3. Updated vaadin-details to use new mixin, and removed vaadin-control-state-mixin package completely.

Fixes #2681

Type of change

  • Refactor (breaking change)

@web-padawan web-padawan added the a11y Accessibility issue label Oct 7, 2021
@web-padawan
web-padawan requested a review from tomivirkki October 7, 2021 09:12
@web-padawan
web-padawan requested a review from vursen October 7, 2021 10:40
@sonarqubecloud

sonarqubecloud Bot commented Oct 7, 2021 •

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan
web-padawan merged commit 7d2b379 into master Oct 7, 2021
@web-padawan
web-padawan deleted the refactor/shadow-focus-mixin branch October 7, 2021 12:44
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with platform 22.0.0.alpha7 and is also targeting the upcoming stable 22.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[details] Update to use new mixins instead of ControlStateMixin

4 participants