Skip to content

feat: add autocomplete attribute to login form - #2847

Merged
web-padawan merged 1 commit into
masterfrom
feat/auto-complete-login-form-2722
Oct 13, 2021
Merged

web-padawan merged 1 commit into
masterfrom
feat/auto-complete-login-form-2722

Conversation

@hdamr

@hdamr hdamr commented Oct 13, 2021

Copy link
Copy Markdown
Contributor

Description

By utilising autocomplete=current-password, we are helping browsers to fill user's saved password for the current site. This PR simply adds the mentioned attribute to password field in vaadin-login-form

Fixes #2126

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with platform 22.0.0.alpha8 and is also targeting the upcoming stable 22.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[login] Password field in a login form should have an autocomplete attribute

3 participants