Skip to content

fix: use active attribute on a root level button while it's expanded - #2889

Merged
tomivirkki merged 5 commits into
masterfrom
menu-bar-active-item
Oct 19, 2021
Merged

tomivirkki merged 5 commits into
masterfrom
menu-bar-active-item

Conversation

@tomivirkki

Copy link
Copy Markdown
Member

Fixes #2734

@tomivirkki tomivirkki added the a11y Accessibility issue label Oct 18, 2021
@jouni

jouni commented Oct 18, 2021

Copy link
Copy Markdown
Member

@tomivirkki

Copy link
Copy Markdown
Member Author

I believe these styles should be removed

Done

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with platform 22.0.0.beta1 and is also targeting the upcoming stable 22.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Insufficient contrast when a top-level "primary" menu item is open

4 participants