Skip to content

fix: open select overlay on label click - #2902

Merged
web-padawan merged 1 commit into
masterfrom
fix/select/open-overlay-on-label-click
Oct 21, 2021
Merged

web-padawan merged 1 commit into
masterfrom
fix/select/open-overlay-on-label-click

Conversation

@vursen

@vursen vursen commented Oct 21, 2021 •

Copy link
Copy Markdown
Contributor

Description

The PR fixes the regression where the select component doesn't open the overlay on the label click.

Fixes #2899

Type of change

  • Bugfix

Checklist

  • I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Comment thread packages/select/src/vaadin-select.js Resolved
@vursen
vursen requested a review from web-padawan October 21, 2021 08:59
Comment thread packages/select/test/select.test.js Resolved
Comment thread packages/select/test/select.test.js Resolved
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with platform 22.0.0.beta1 and is also targeting the upcoming stable 22.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[select] Label click does not open dropdown in V22

4 participants