Repository navigation
chore: update vaadin-combo-box theming docs - #2920
Merged
Merged
Conversation
* mention that vaadin-combo-box includes parts and states from vaadin-text-field * remove text-field part, which doesn't exist * remove duplicate state attributes that are covered by vaadin-text-field * remove mention of internal vaadin-text-field component, combo box does not have an internal text field * add missing checkmark part to vaadin-combo-box-item
tomivirkki
approved these changes
Oct 25, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
Collaborator
|
This ticket/PR has been released with platform 22.0.0.beta1 and is also targeting the upcoming stable 22.0.0 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
Updates vaadin-combo-box theme docs:
Might be wrong about it including all parts and states from vaadin-text-field, if so let's figure out which are actually supported and document them individually instead of linking to text field.