Skip to content

chore: update vaadin-combo-box theming docs - #2920

Merged
sissbruecker merged 2 commits into
masterfrom
fix/combobox_theme_docs
Oct 25, 2021
Merged

sissbruecker merged 2 commits into
masterfrom
fix/combobox_theme_docs

Conversation

@sissbruecker

Copy link
Copy Markdown
Member

Description

Updates vaadin-combo-box theme docs:

  • mention that vaadin-combo-box includes parts and states from vaadin-text-field
  • remove text-field part, which doesn't exist
  • remove duplicate state attributes that are covered by vaadin-text-field
  • remove mention of internal vaadin-text-field component, combo box does not have an internal text field
  • add missing checkmark part to vaadin-combo-box-item

Might be wrong about it including all parts and states from vaadin-text-field, if so let's figure out which are actually supported and document them individually instead of linking to text field.

* mention that vaadin-combo-box includes parts and states from vaadin-text-field
* remove text-field part, which doesn't exist
* remove duplicate state attributes that are covered by vaadin-text-field
* remove mention of internal vaadin-text-field component, combo box does not have an internal text field
* add missing checkmark part to vaadin-combo-box-item
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sissbruecker
sissbruecker merged commit 3eaa3aa into master Oct 25, 2021
@sissbruecker
sissbruecker deleted the fix/combobox_theme_docs branch October 25, 2021 12:30
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with platform 22.0.0.beta1 and is also targeting the upcoming stable 22.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants