Skip to content

fix: inherit input field font from the host - #2933

Merged
tomivirkki merged 3 commits into
masterfrom
inherit-input-field-styles
Oct 27, 2021
Merged

tomivirkki merged 3 commits into
masterfrom
inherit-input-field-styles

Conversation

@tomivirkki

Copy link
Copy Markdown
Member

Fixes #2884

@tomivirkki
tomivirkki marked this pull request as ready for review October 26, 2021 14:12
@tomivirkki

Copy link
Copy Markdown
Member Author

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan

Copy link
Copy Markdown
Member

@jouni PTAL. If the change looks good, we should merge it so it will be included to 22.0.0-beta1.

@jouni jouni left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright.

My hesitation comes from the confusion how we should handle inherited properties in our components in general. We should be consistent with it across all components, have guidelines when to inherit and when to explicitly override.

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with platform 22.0.0.beta1 and is also targeting the upcoming stable 22.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Input fields: setting font size on the host not inherited to input

4 participants