Skip to content

refactor: use FocusMixin instead of custom logic - #2966

Merged
web-padawan merged 3 commits into
masterfrom
refactor/focus-ring-avatar
Nov 2, 2021
Merged

web-padawan merged 3 commits into
masterfrom
refactor/focus-ring-avatar

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

The only reason for copy-paste in the original implementation was the lack of FocusMixin back then.
Note, we can change the tests separately to use sendKeys - for now current tests might be OK.

Type of change

  • Refactor

@web-padawan
web-padawan requested a review from vursen November 2, 2021 11:40
@sonarqubecloud

sonarqubecloud Bot commented Nov 2, 2021

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with platform 22.0.0.beta2 and is also targeting the upcoming stable 22.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants