Repository navigation
feat: add user colors to Lumo and Material styles - #3025
Conversation
|
|
||
| const userColors = css` | ||
| :host { | ||
| --vaadin-user-color-0: #df0b92; |
|
|
||
| const userColors = css` | ||
| :host { | ||
| --vaadin-user-color-0: #ab47bc; |
|
Looks good overall. Just to confirm, do we still want to call them "user colors" in this context if they're not specifically related to "users" (but available for any use case)? |
|
That's a good point. Ideally we would can keep the current API as is, but now is the right moment to change it. |
|
I did have similar thoughts when I looked at this PR. Ideally, I think, we should offer a fuller palette of color scales (think of Tailwind/Radix/etc, with blue/red/green/teal/purple/indigo/etc from 50–900/1–12), which could then be applied for this use case. But I also feel like it might still make sense to have this semantic layer of custom properties for this use case (similar to, for example, What other potential use cases did Tomi have in mind for these colors? I admit I don't have clear enough thoughts about this at the moment. |
|
For now the colors are used by field highlighter and |
Was mainly referencing this #1604 (comment) |
We could have more generic names e.g. UPD: we do have web-components/packages/message-list/src/vaadin-message.js Lines 113 to 115 in cf670b4 |
jouni
left a comment
There was a problem hiding this comment.
I think we can keep the existing property names. We can re-evaluate that in the future if needed.
|
Kudos, SonarCloud Quality Gate passed!
|
|
This ticket/PR has been released with platform 23.0.0. |








Description
<custom-style>,avatarpackage to import the newly added style modules in Lumo and Material themes,avatarnow imports them),Fixes #1604
Type of change
Checklist