Repository navigation
refactor!: split the crud filter/sorter cell on separate rows - #3032
Merged
Merged
Conversation
tomivirkki
marked this pull request as draft
November 12, 2021 14:10
tomivirkki
marked this pull request as ready for review
November 12, 2021 14:45
web-padawan
reviewed
Nov 15, 2021
web-padawan
left a comment
Member
There was a problem hiding this comment.
LGTM, added a few minor comments.
One idea for separate issue / PR: make it possible to change the renderers when setting crud.noSort = true or crud.noFilter = true dynamically, after the CRUD was initialized.
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
web-padawan
approved these changes
Nov 15, 2021
vursen
reviewed
Nov 18, 2021
vursen
reviewed
Nov 18, 2021
tomivirkki
force-pushed
the
split-crud-header
branch
from
November 22, 2021 09:42
2b5b416 to
ae3d3af
Compare
vursen
reviewed
Nov 23, 2021
vursen
approved these changes
Nov 23, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
36 tasks
Collaborator
|
This ticket/PR has been released with platform 23.0.0.alpha1 and is also targeting the upcoming stable 23.0.0 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Fixes #1965