Skip to content

refactor!: split the crud filter/sorter cell on separate rows - #3032

Merged
tomivirkki merged 20 commits into
masterfrom
split-crud-header
Nov 23, 2021
Merged

tomivirkki merged 20 commits into
masterfrom
split-crud-header

Conversation

@tomivirkki

Copy link
Copy Markdown
Member

Fixes #1965

@tomivirkki
tomivirkki marked this pull request as draft November 12, 2021 14:10
@tomivirkki
tomivirkki marked this pull request as ready for review November 12, 2021 14:45
@tomivirkki tomivirkki changed the title refactor: split the crud filter/sorter cell on separate rows refactor!: split the crud filter/sorter cell on separate rows Nov 15, 2021

@web-padawan web-padawan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added a few minor comments.

One idea for separate issue / PR: make it possible to change the renderers when setting crud.noSort = true or crud.noFilter = true dynamically, after the CRUD was initialized.

Comment thread packages/crud/src/vaadin-crud-grid.js Resolved
Comment thread packages/crud/src/vaadin-crud-grid.js Resolved
Comment thread packages/crud/src/vaadin-crud-grid.js Resolved
tomivirkki and others added 3 commits November 15, 2021 14:20
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
Comment thread packages/crud/src/vaadin-crud-grid.js Resolved
Comment thread packages/crud/src/vaadin-crud-grid.js Resolved
Comment thread packages/crud/src/vaadin-crud-grid.js Resolved
@web-padawan
web-padawan removed the request for review from sosa-vaadin November 18, 2021 14:01
Comment thread packages/crud/src/vaadin-crud-grid.js Resolved
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tomivirkki
tomivirkki merged commit 9735416 into master Nov 23, 2021
@tomivirkki
tomivirkki deleted the split-crud-header branch November 23, 2021 11:59
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with platform 23.0.0.alpha1 and is also targeting the upcoming stable 23.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[crud] Split the crud sorter/filter controls in separate cells

4 participants