Skip to content

feat: add a required indicator to form item - #3057

Merged
tomivirkki merged 12 commits into
masterfrom
form-item-required-indicator
Nov 17, 2021
Merged

tomivirkki merged 12 commits into
masterfrom
form-item-required-indicator

Conversation

@tomivirkki

Copy link
Copy Markdown
Member

Closes #835

@tomivirkki
tomivirkki marked this pull request as draft November 16, 2021 13:10
@tomivirkki
tomivirkki force-pushed the form-item-required-indicator branch from a3b2ab0 to 92e7c68 Compare November 16, 2021 13:29
@tomivirkki
tomivirkki force-pushed the form-item-required-indicator branch from 92e7c68 to 68f0020 Compare November 16, 2021 13:30
@tomivirkki
tomivirkki marked this pull request as ready for review November 16, 2021 13:30

@web-padawan web-padawan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basic screenshot is updated but only for Lumo, wondering what's wrong there.

tomivirkki and others added 4 commits November 17, 2021 10:53
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tomivirkki
tomivirkki merged commit 0c7f682 into master Nov 17, 2021
@tomivirkki
tomivirkki deleted the form-item-required-indicator branch November 17, 2021 12:21
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with platform 23.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[form-layout] Form item label doesn't show indicator for required fields

3 participants