Skip to content

refactor!: update confirm-dialog to make styling easier - #3135

Merged
web-padawan merged 8 commits into
masterfrom
refactor/confirm-dialog
Dec 2, 2021
Merged

web-padawan merged 8 commits into
masterfrom
refactor/confirm-dialog

Conversation

@web-padawan

@web-padawan web-padawan commented Nov 30, 2021 •

Copy link
Copy Markdown
Member

Description

Same as #3108 but for vaadin-confirm-dialog. Part of logic for handling slotted nodes is copied from vaadin-crud.

Fixes #503
Fixes #709
Fixes #932 by getting rid of class names
Fixes #974 by adding click listeners

Type of change

  • Breaking change

@web-padawan web-padawan added the a11y Accessibility issue label Nov 30, 2021
@web-padawan
web-padawan force-pushed the refactor/confirm-dialog branch from d4a08f9 to fd57a5d Compare November 30, 2021 20:55

@jouni jouni left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should vaadin-confirm-dialog-dialog.js be vaadin-confirm-dialog-overlay.js?

@web-padawan
web-padawan force-pushed the refactor/confirm-dialog branch from 7f316ec to 61b8171 Compare December 1, 2021 10:18
@web-padawan

Copy link
Copy Markdown
Member Author

Should vaadin-confirm-dialog-dialog.js be vaadin-confirm-dialog-overlay.js?

Good point, done.

@web-padawan
web-padawan force-pushed the refactor/confirm-dialog branch 2 times, most recently from 8d35c1e to dd862d5 Compare December 2, 2021 08:41
Comment thread dev/confirm-dialog.html Resolved

@tomivirkki tomivirkki left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@web-padawan
web-padawan removed the request for review from jouni December 2, 2021 16:48
@web-padawan
web-padawan force-pushed the refactor/confirm-dialog branch from 3b6e4bf to a88dc02 Compare December 2, 2021 16:56
@sonarqubecloud

sonarqubecloud Bot commented Dec 2, 2021

Copy link
Copy Markdown

Please retry analysis of this Pull-Request directly on SonarCloud.

@web-padawan
web-padawan merged commit cae4c09 into master Dec 2, 2021
@web-padawan
web-padawan deleted the refactor/confirm-dialog branch December 2, 2021 17:12
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with platform 23.0.0.alpha1 and is also targeting the upcoming stable 23.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

5 participants