Repository navigation
refactor!: update confirm-dialog to make styling easier - #3135
Merged
Merged
Conversation
web-padawan
force-pushed
the
refactor/confirm-dialog
branch
from
November 30, 2021 20:55
d4a08f9 to
fd57a5d
Compare
knoobie
reviewed
Nov 30, 2021
jouni
reviewed
Dec 1, 2021
jouni
left a comment
Member
There was a problem hiding this comment.
Should vaadin-confirm-dialog-dialog.js be vaadin-confirm-dialog-overlay.js?
tomivirkki
reviewed
Dec 1, 2021
web-padawan
force-pushed
the
refactor/confirm-dialog
branch
from
December 1, 2021 10:18
7f316ec to
61b8171
Compare
Member
Author
Good point, done. |
web-padawan
force-pushed
the
refactor/confirm-dialog
branch
2 times, most recently
from
December 2, 2021 08:41
8d35c1e to
dd862d5
Compare
tomivirkki
reviewed
Dec 2, 2021
tomivirkki
approved these changes
Dec 2, 2021
Co-authored-by: Tomi Virkki <tomivirkki@users.noreply.github.com>
web-padawan
force-pushed
the
refactor/confirm-dialog
branch
from
December 2, 2021 16:56
3b6e4bf to
a88dc02
Compare
|
Please retry analysis of this Pull-Request directly on SonarCloud. |
36 tasks
Collaborator
|
This ticket/PR has been released with platform 23.0.0.alpha1 and is also targeting the upcoming stable 23.0.0 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Same as #3108 but for
vaadin-confirm-dialog. Part of logic for handling slotted nodes is copied fromvaadin-crud.Fixes #503
Fixes #709
Fixes #932 by getting rid of class names
Fixes #974 by adding click listeners
Type of change