Skip to content

fix: update date picker observer to mind the new structure - #3142

Merged
web-padawan merged 1 commit into
masterfrom
fix-date-picker-observer
Dec 2, 2021
Merged

web-padawan merged 1 commit into
masterfrom
fix-date-picker-observer

Conversation

@tomivirkki

Copy link
Copy Markdown
Member

A fix derived from #3138

This makes the date picker observer in the field highlighter mind the new component structure; the date picker's focusable node is the input in the light DOM

@sonarqubecloud

sonarqubecloud Bot commented Dec 2, 2021

Copy link
Copy Markdown

Please retry analysis of this Pull-Request directly on SonarCloud.

@web-padawan
web-padawan merged commit d951519 into master Dec 2, 2021
@web-padawan
web-padawan deleted the fix-date-picker-observer branch December 2, 2021 16:51
@vaadin-bot

Copy link
Copy Markdown
Collaborator

Hi @tomivirkki , this commit cannot be picked to 22.0 by this bot, can you take a look and pick it manually?
Error Message: Error: Command failed: git cherry-pick d951519
error: could not apply d951519... fix: update date-picker observer to mind the new structure (#3142)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' or 'git rm '
hint: and commit the result with 'git commit'

@web-padawan

Copy link
Copy Markdown
Member

We don't have field highlighter in Vaadin 22, I will pick the fix to the CE repo manually tomorrow.

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with platform 23.0.0.alpha1 and is also targeting the upcoming stable 23.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants