Repository navigation
fix: update date picker observer to mind the new structure - #3142
Merged
Merged
Conversation
tomivirkki
force-pushed
the
fix-date-picker-observer
branch
from
December 2, 2021 09:57
2d62103 to
6532412
Compare
|
Please retry analysis of this Pull-Request directly on SonarCloud. |
web-padawan
approved these changes
Dec 2, 2021
Collaborator
|
Hi @tomivirkki , this commit cannot be picked to 22.0 by this bot, can you take a look and pick it manually? |
Member
|
We don't have field highlighter in Vaadin 22, I will pick the fix to the CE repo manually tomorrow. |
Collaborator
|
This ticket/PR has been released with platform 23.0.0.alpha1 and is also targeting the upcoming stable 23.0.0 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fix derived from #3138
This makes the date picker observer in the field highlighter mind the new component structure; the date picker's focusable node is the
inputin the light DOM