Repository navigation
feat: Distinct styling for anchors without href - #3204
Merged
Merged
Conversation
… added a disabled text color for anchors without href (so that Flow can remove the href to make anchors disabled)
|
Kudos, SonarCloud Quality Gate passed!
|
jouni
approved these changes
Dec 20, 2021
mstahv
approved these changes
Dec 29, 2021
web-padawan
approved these changes
Dec 29, 2021
Collaborator
|
This ticket/PR has been released with platform 23.0.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Flow intends to use (temporary) href attribute removal to disable anchors (as they lack a native disabled state), see vaadin/flow#10924. This PR changes Lumo styling of anchors so that the regular styling is applied only to anchors with href (using the
:any-linkpseudoclass) and Lumo disabled text color is instead applied to those without.Potential breaking change: if an app contains href-less anchors (and e.g. use click event to do stuff instead) they will now have a disabled text color. However, at least Flow apps are almost guaranteed to have an empty href rather than missing one (unless developer has explicitly removed the empty href), so this is very unlikely to affect Flow-based apps.
Fixes #1594
Type of change
Checklist
Additional for
Featuretype of change