Repository navigation
fix: ensure focused month is visible when receiving focus - #3219
Merged
Merged
Conversation
vursen
commented
Dec 24, 2021
vursen
force-pushed
the
fix/date-picker/reveal-date
branch
from
December 24, 2021 11:24
0b79702 to
5c825d6
Compare
vursen
force-pushed
the
fix/date-picker/reveal-date
branch
from
January 5, 2022 17:24
5c825d6 to
c436092
Compare
vursen
marked this pull request as ready for review
January 6, 2022 07:45
web-padawan
reviewed
Jan 6, 2022
tomivirkki
reviewed
Jan 7, 2022
vursen
force-pushed
the
fix/date-picker/reveal-date
branch
from
January 7, 2022 10:06
59d11ff to
1532c89
Compare
tomivirkki
approved these changes
Jan 7, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
web-padawan
approved these changes
Jan 7, 2022
Collaborator
|
Hi @vursen , this commit cannot be picked to 22.0 by this bot, can you take a look and pick it manually? |
vursen
added a commit
that referenced
this pull request
Jan 7, 2022
This was referenced Jan 7, 2022
web-padawan
pushed a commit
that referenced
this pull request
Jan 10, 2022
web-padawan
pushed a commit
that referenced
this pull request
Jan 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
This PR fixes the bug where a month receiving focus by the keyboard or programmatically sometimes wasn't scrolled into the visible area of the calendar.
An investigation established that the bug is caused by the buffer offset that can be set with the
--vaadin-infinite-scroller-buffer-offsetCSS variable. This offset isn't taken into account by therevealDatemethod which leads to computing an erroneously greater number of visible months when an offset is set and, as a result, scrolling doesn't happen. Worth noting that the buffer offset is a non-zero value in both Lumo and Material themes so both themes are affected.💡tip: When reviewing this PR, enable the "Hide whitespace" option to reduce the diff.
Fixes #1892
Type of change
Checklist