Skip to content

fix: cleanup slot attribute on removed nodes - #3396

Merged
web-padawan merged 1 commit into
masterfrom
fix/split-layout-slot
Feb 4, 2022
Merged

web-padawan merged 1 commit into
masterfrom
fix/split-layout-slot

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

Added logic to remove slot attribute when nodes are removed from split-layout.

Fixes vaadin/flow-components#2581

Type of change

  • Bugfix

@sonarqubecloud

sonarqubecloud Bot commented Feb 4, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan
web-padawan merged commit 7661fa0 into master Feb 4, 2022
@web-padawan
web-padawan deleted the fix/split-layout-slot branch February 4, 2022 14:29
@vaadin-bot

Copy link
Copy Markdown
Collaborator

Hi @web-padawan , this commit cannot be picked to 22.0 by this bot, can you take a look and pick it manually?
Error Message: Error: Command failed: git cherry-pick 7661fa0
error: could not apply 7661fa0... fix: cleanup slot attribute on removed nodes (#3396)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' or 'git rm '
hint: and commit the result with 'git commit'

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with platform 23.0.0.beta2 and is also targeting the upcoming stable 23.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Moving a child from a split layout to another container does not work

3 participants