Skip to content

feat: make map accessible through keyboard - #3403

Merged
web-padawan merged 6 commits into
masterfrom
feat/map_keyboard_accessibility
Feb 10, 2022
Merged

web-padawan merged 6 commits into
masterfrom
feat/map_keyboard_accessibility

Conversation

@sissbruecker

@sissbruecker sissbruecker commented Feb 7, 2022 •

Copy link
Copy Markdown
Member

Description

Enables keyboard accessibility features in the OpenLayers map, and adds focus ring. Also changes the default interactions to allow mouse-wheel zoom and drag-pan while the map is not focused. This behaviour should be configurable at some point, but for now we can use this as sefault

Fixes vaadin/flow-components#2515

@sissbruecker
sissbruecker force-pushed the feat/map_keyboard_accessibility branch from 24cab7d to 23c1812 Compare February 9, 2022 13:50
@sissbruecker
sissbruecker marked this pull request as ready for review February 9, 2022 13:51

@web-padawan web-padawan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, two small comments.

Comment thread packages/map/src/vaadin-map.js Resolved
Comment thread packages/map/src/vaadin-map.js Resolved
@sissbruecker
sissbruecker force-pushed the feat/map_keyboard_accessibility branch from fe5cb93 to ea47fff Compare February 10, 2022 09:29
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan
web-padawan merged commit b541f43 into master Feb 10, 2022
@web-padawan
web-padawan deleted the feat/map_keyboard_accessibility branch February 10, 2022 09:39
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with platform 23.0.0.beta2 and is also targeting the upcoming stable 23.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[map] Accessibility

3 participants