Repository navigation
feat: make map accessible through keyboard - #3403
Merged
Merged
Conversation
sissbruecker
force-pushed
the
feat/map_keyboard_accessibility
branch
from
February 9, 2022 13:50
24cab7d to
23c1812
Compare
sissbruecker
marked this pull request as ready for review
February 9, 2022 13:51
web-padawan
approved these changes
Feb 10, 2022
web-padawan
left a comment
Member
There was a problem hiding this comment.
LGTM, two small comments.
web-padawan
reviewed
Feb 10, 2022
sissbruecker
force-pushed
the
feat/map_keyboard_accessibility
branch
from
February 10, 2022 09:29
fe5cb93 to
ea47fff
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
web-padawan
approved these changes
Feb 10, 2022
Collaborator
|
This ticket/PR has been released with platform 23.0.0.beta2 and is also targeting the upcoming stable 23.0.0 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
Enables keyboard accessibility features in the OpenLayers map, and adds focus ring. Also changes the default interactions to allow mouse-wheel zoom and drag-pan while the map is not focused. This behaviour should be configurable at some point, but for now we can use this as sefault
Fixes vaadin/flow-components#2515