Skip to content

fix: check last custom value on focusout - #3485

Merged
web-padawan merged 1 commit into
masterfrom
fix/focusout-custom-value
Feb 23, 2022
Merged

web-padawan merged 1 commit into
masterfrom
fix/focusout-custom-value

Conversation

@web-padawan

@web-padawan web-padawan commented Feb 23, 2022 •

Copy link
Copy Markdown
Member

Description

Updated the original fix to only check last custom value on focusout where the actual problem manifested.
To me it seems like a cleaner approach than attempting to reset that flag in all the possible cases.

Fixes vaadin/flow-components#2523

Type of change

  • Bugfix

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sissbruecker sissbruecker left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Did check with some testing in web-components and ran the failing Flow IT. The latter one fails randomly (for other tests than the one that broke yesterday), but that seems to be related to the test not handling the virtualizer correctly.

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with platform 23.0.0.rc1 and is also targeting the upcoming stable 23.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ComboBox calls CustomValueSetListener twice

3 participants