Skip to content

test: update number-field tests to avoid loops - #3489

Merged
web-padawan merged 1 commit into
masterfrom
test/number-field-loops
Feb 25, 2022
Merged

web-padawan merged 1 commit into
masterfrom
test/number-field-loops

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

When converting vaadin-number-field to LitElement, I discovered that some tests are using forEach loops.
With Polymer it's fine as updates are synchronous, but with LitElement we need await field.updateComplete

Refactored such tests to use forEach loops for creating many tests vs only one test with many assertions.

Type of change

  • Tests

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan
web-padawan merged commit cd312e5 into master Feb 25, 2022
@web-padawan
web-padawan deleted the test/number-field-loops branch February 25, 2022 13:39
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with platform 23.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants