Skip to content

refactor: use inline style for cell transform - #3605

Merged
tomivirkki merged 3 commits into
masterfrom
fix-frozen-transform-performance
Mar 25, 2022
Merged

tomivirkki merged 3 commits into
masterfrom
fix-frozen-transform-performance

Conversation

@tomivirkki

Copy link
Copy Markdown
Member

@tomivirkki
tomivirkki marked this pull request as draft March 25, 2022 09:16
@tomivirkki
tomivirkki force-pushed the fix-frozen-transform-performance branch from 98f2d55 to c0136a7 Compare March 25, 2022 10:47
@tomivirkki
tomivirkki force-pushed the fix-frozen-transform-performance branch from 7c3cae4 to 55b55cc Compare March 25, 2022 11:31

flushGrid(grid);

// Force reflow to workaround a Safari rendering issue

@tomivirkki tomivirkki Mar 25, 2022 •

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed to workaround a Safari rendering issue in the test case. Seems that the test renders funny on master also (even though it oddly passes):

Kapture.2022-03-25.at.13.27.39.mp4

@tomivirkki
tomivirkki marked this pull request as ready for review March 25, 2022 11:37
@tomivirkki
tomivirkki requested a review from web-padawan March 25, 2022 11:37

@web-padawan web-padawan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks 🙇‍♂️

@web-padawan web-padawan changed the title perf: use inline style for cell transform refactor: use inline style for cell transform Mar 25, 2022
@tomivirkki
tomivirkki force-pushed the fix-frozen-transform-performance branch from 1a2f89a to 5eb479c Compare March 25, 2022 13:25
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 23.1.0.alpha1 and is also targeting the upcoming stable 23.1.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Slow renderer/scroll horizontal in grid with many columns Vaadin 23.0.x

3 participants