Skip to content

refactor: add more rules to Prettier config, fix warnings - #3725

Merged
vursen merged 7 commits into
masterfrom
prettier/add-rules
Apr 26, 2022
Merged

vursen merged 7 commits into
masterfrom
prettier/add-rules

Conversation

@vursen

@vursen vursen commented Apr 23, 2022 •

Copy link
Copy Markdown
Contributor

Description

The PR adds the following rules to the project's Prettier config:

  • tabWidth: 2 (0 files changed)
  • bracketSpacing: true (0 files changed)
  • trailingComma: all (675 files changed)

See the upcoming Prettier config by Vaadin as a reference.

Part of vaadin/eslint-config-vaadin#16

Type of change

  • Internal

Checklist

  • I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@vursen
vursen requested review from web-padawan and removed request for web-padawan April 23, 2022 09:52
@vursen
vursen marked this pull request as draft April 23, 2022 10:00
@vursen
vursen requested a review from web-padawan April 23, 2022 11:19
@vursen
vursen force-pushed the prettier/add-rules branch from aad6c44 to b9b377b Compare April 23, 2022 11:21
@vursen
vursen marked this pull request as ready for review April 23, 2022 11:21
@vursen
vursen force-pushed the prettier/add-rules branch 2 times, most recently from 417b1d5 to 0e97f12 Compare April 26, 2022 08:36
@vursen
vursen force-pushed the prettier/add-rules branch from 0e97f12 to 3b51b47 Compare April 26, 2022 08:39
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.4% 2.4% Duplication

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 23.1.0.alpha4 and is also targeting the upcoming stable 23.1.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants