Skip to content

refactor: add more rules to ESLint config, fix warnings (2) - #3727

Merged
vursen merged 4 commits into
masterfrom
eslint/add-rules-6
Apr 25, 2022
Merged

vursen merged 4 commits into
masterfrom
eslint/add-rules-6

Conversation

@vursen

@vursen vursen commented Apr 23, 2022 •

Copy link
Copy Markdown
Contributor

Description

The PR adds the following rules to the project's ESLint config:

  • eqeqeq

Along the way, I also replaced indexOf(...) !== -1 with includes(...).

Part of vaadin/eslint-config-vaadin#16

Type of change

  • Internal

Checklist

  • I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

if (!arrayEquals(arr1[i], arr2[i])) {
return false;
}
} else if (arr1[i] !== arr2[i]) {

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note:

- } else if (arr1[i] != arr2[i]) {
+ } else if (arr1[i] !== arr2[i]) {

@vursen
vursen requested a review from web-padawan April 25, 2022 06:54
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vursen
vursen merged commit 9690936 into master Apr 25, 2022
@vursen
vursen deleted the eslint/add-rules-6 branch April 25, 2022 09:29
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 23.1.0.alpha4 and is also targeting the upcoming stable 23.1.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants