Repository navigation
fix: make header-title be announced by screen readers - #3760
Merged
Merged
Conversation
Make header-title set `aria-label` instead of using `aria-labelleby` as it seems that Chrome + VoiceOver is not capable of announce the later. Make sure that the `aria-label` property set on the dialog is set in case both `aria-label` and `header-title` are defined. Change the markup of the resize container from `<div>` to `<section>`. Fix #3702
web-padawan
reviewed
May 2, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
web-padawan
approved these changes
May 2, 2022
Collaborator
|
This ticket/PR has been released with Vaadin 23.1.0.beta1 and is also targeting the upcoming stable 23.1.0 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
aria-labelinstead of usingaria-labellebyas it seems that Chrome + VoiceOver is not capable of announce the later.aria-labelproperty set on the dialog is set in case botharia-labelandheader-titleare defined.<div>to<section>.Fixes #3702