Skip to content

fix: make header-title be announced by screen readers - #3760

Merged
web-padawan merged 2 commits into
masterfrom
fix/dialog-header-a11y
May 2, 2022
Merged

web-padawan merged 2 commits into
masterfrom
fix/dialog-header-a11y

Conversation

@DiegoCardoso

Copy link
Copy Markdown
Contributor

Description

  • Make header-title set aria-label instead of using aria-labelleby as it seems that Chrome + VoiceOver is not capable of announce the later.
  • Make sure that the aria-label property set on the dialog is set in case both aria-label and header-title are defined.
  • Change the markup of the resize container from <div> to <section>.

Fixes #3702

Make header-title set `aria-label` instead of using `aria-labelleby` as
it seems that Chrome + VoiceOver is not capable of announce the later.
Make sure that the `aria-label` property set on the dialog is set in
case both `aria-label` and `header-title` are defined.
Change the markup of the resize container from `<div>` to `<section>`.

Fix #3702
Comment thread packages/dialog/src/vaadin-dialog.js Resolved
@sonarqubecloud

sonarqubecloud Bot commented May 2, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 23.1.0.beta1 and is also targeting the upcoming stable 23.1.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[dialog] Ensure title is announced by screen readers

3 participants