Skip to content

test: add LitElement tests for input mixins - #3795

Merged
web-padawan merged 1 commit into
masterfrom
test/lit-field-base-1
May 7, 2022
Merged

web-padawan merged 1 commit into
masterfrom
test/lit-field-base-1

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

Updated some of the field-base mixins to run tests for both Polymer and LitElement:

  • DelegateStateMixin
  • InputConstraintsMixin
  • InputMixin
  • PatternMixin
  • ValidateMixin

Type of change

  • Tests

@web-padawan
web-padawan requested review from tomivirkki and vursen May 6, 2022 11:44
@sonarqubecloud

sonarqubecloud Bot commented May 6, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vursen

vursen commented May 6, 2022 •

Copy link
Copy Markdown
Contributor

It could probably make sense to split Polymer and Lit tests into separate files to let the web-test-runner run them in parallel when possible.

@web-padawan
web-padawan removed the request for review from vursen May 7, 2022 08:03
@web-padawan

Copy link
Copy Markdown
Member Author

It could probably make sense to split Polymer and Lit tests

We can think of it later when we get to merging PRs for components with more tests. It would probably make sense to even have a separate workflow in CI.

@web-padawan
web-padawan merged commit 1994750 into master May 7, 2022
@web-padawan
web-padawan deleted the test/lit-field-base-1 branch May 7, 2022 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants