Repository navigation
test: speed up the keyboard tests - #3798
Merged
Merged
Conversation
vursen
commented
May 6, 2022
|
|
||
| static get properties() { | ||
| return { | ||
| scrollDuration: { |
Contributor
Author
There was a problem hiding this comment.
It is an internal component, so I thought it doesn't matter whether the property should start with _ or not.
tomivirkki
reviewed
May 6, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
tomivirkki
approved these changes
May 6, 2022
web-padawan
approved these changes
May 6, 2022
vaadin-bot
pushed a commit
that referenced
this pull request
May 6, 2022
vursen
added a commit
that referenced
this pull request
May 6, 2022
Co-authored-by: Sergey Vinogradov <mr.vursen@gmail.com> Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
This PR sets the scroll duration to
0for the date-picker keyboard tests to speed them up.Here are the results I got on my M1 machine:
Before:
After:
Type of change
Checklist