Skip to content

test: speed up the keyboard tests - #3798

Merged
web-padawan merged 1 commit into
masterfrom
test/speed-up-date-picker-tests
May 6, 2022
Merged

web-padawan merged 1 commit into
masterfrom
test/speed-up-date-picker-tests

Conversation

@vursen

@vursen vursen commented May 6, 2022 •

Copy link
Copy Markdown
Contributor

Description

This PR sets the scroll duration to 0 for the date-picker keyboard tests to speed them up.

Here are the results I got on my M1 machine:

Before:

yarn run v1.22.18
$ web-test-runner --group date-picker

Finished running tests in 14.2s, all tests passed! 🎉

✨  Done in 14.67s.

After:

yarn run v1.22.18
$ web-test-runner --group date-picker

Finished running tests in 4.9s, all tests passed! 🎉

✨  Done in 5.28s.

Type of change

  • Internal

Checklist

  • I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.


static get properties() {
return {
scrollDuration: {

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is an internal component, so I thought it doesn't matter whether the property should start with _ or not.

@vursen
vursen requested a review from web-padawan May 6, 2022 12:37
@sonarqubecloud

sonarqubecloud Bot commented May 6, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan
web-padawan merged commit 003c16e into master May 6, 2022
@web-padawan
web-padawan deleted the test/speed-up-date-picker-tests branch May 6, 2022 12:45
vaadin-bot pushed a commit that referenced this pull request May 6, 2022
vursen added a commit that referenced this pull request May 6, 2022
Co-authored-by: Sergey Vinogradov <mr.vursen@gmail.com>
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants