Skip to content

refactor: add more rules to ESLint config, fix warnings (3) - #3803

Merged
vursen merged 2 commits into
masterfrom
eslint/add-rules-13
May 9, 2022
Merged

vursen merged 2 commits into
masterfrom
eslint/add-rules-13

Conversation

@vursen

@vursen vursen commented May 6, 2022 •

Copy link
Copy Markdown
Contributor

Description

The PR adds the following rules to the project's ESLint config:

  • @typescript-eslint/method-signature-style

Part of vaadin/eslint-config-vaadin#16

Type of change

  • Internal

Checklist

  • I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@vursen vursen changed the title refactor: add more rules to ESLint config, fix warnings refactor: add more rules to ESLint config, fix warnings (3) May 6, 2022
@sonarqubecloud

sonarqubecloud Bot commented May 6, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@vursen
vursen merged commit 0c0d5ea into master May 9, 2022
@vursen
vursen deleted the eslint/add-rules-13 branch May 9, 2022 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants