Skip to content

fix: prevent overriding column hidden state when attaching column group - #3805

Merged
sissbruecker merged 3 commits into
masterfrom
fix/column_hidden_override_alternative
May 10, 2022
Merged

sissbruecker merged 3 commits into
masterfrom
fix/column_hidden_override_alternative

Conversation

@sissbruecker

Copy link
Copy Markdown
Member

Description

Fixes the column group to not synchronize its hidden state to child columns when it is attached, and visible. The change restructures the hidden logic to hopefully be a bit more clearer, and manages to remove one state property for the synchronization, as well as some observers.

Fixes vaadin/flow-components#2959

Type of change

  • Bugfix

@tomivirkki tomivirkki left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally seems to work well. Added one question.

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sissbruecker
sissbruecker merged commit e7ce34a into master May 10, 2022
@sissbruecker
sissbruecker deleted the fix/column_hidden_override_alternative branch May 10, 2022 13:38
@vaadin-bot

Copy link
Copy Markdown
Collaborator

Hi @sissbruecker , this commit cannot be picked to 23.0 by this bot, can you take a look and pick it manually?
Error Message: Error: Command failed: git cherry-pick e7ce34a
error: could not apply e7ce34a... fix: prevent overriding column hidden state when attaching column group (#3805)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot

Copy link
Copy Markdown
Collaborator

Hi @sissbruecker , this commit cannot be picked to 22.0 by this bot, can you take a look and pick it manually?
Error Message: Error: Command failed: git cherry-pick e7ce34a
error: could not apply e7ce34a... fix: prevent overriding column hidden state when attaching column group (#3805)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

sissbruecker added a commit that referenced this pull request May 10, 2022
…up (#3805)

* fix: prevent column group overriding column hidden state

* add regression test

* automatically update auto hidden after updating visible columns

(cherry picked from commit e7ce34a)
sissbruecker added a commit to vaadin/vaadin-grid that referenced this pull request May 10, 2022
…up (#3805) (CP: 14.8)

Fixes the column group to not synchronize its hidden state to child columns when it is attached, and visible.

Fixes vaadin/flow-components#2959
Cherry-pick of: vaadin/web-components#3805
sissbruecker added a commit that referenced this pull request May 11, 2022
…up (#3805) (#3821) (#3825)

Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
sissbruecker added a commit to vaadin/vaadin-grid that referenced this pull request May 11, 2022
…up (CP: 14.8) (#2216)

* fix: prevent overriding column hidden state when attaching column group (#3805) (CP: 14.8)

Fixes the column group to not synchronize its hidden state to child columns when it is attached, and visible.

Fixes vaadin/flow-components#2959
Cherry-pick of: vaadin/web-components#3805

* remove obsolete hidden check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[grid] Hidden grouped columns are still shown when hiding them during initialization

3 participants