Repository navigation
fix: prevent overriding column hidden state when attaching column group - #3805
Conversation
tomivirkki
left a comment
There was a problem hiding this comment.
Generally seems to work well. Added one question.
|
Kudos, SonarCloud Quality Gate passed!
|
|
Hi @sissbruecker , this commit cannot be picked to 23.0 by this bot, can you take a look and pick it manually? |
|
Hi @sissbruecker , this commit cannot be picked to 22.0 by this bot, can you take a look and pick it manually? |
…up (#3805) (CP: 14.8) Fixes the column group to not synchronize its hidden state to child columns when it is attached, and visible. Fixes vaadin/flow-components#2959 Cherry-pick of: vaadin/web-components#3805
…up (CP: 14.8) (#2216) * fix: prevent overriding column hidden state when attaching column group (#3805) (CP: 14.8) Fixes the column group to not synchronize its hidden state to child columns when it is attached, and visible. Fixes vaadin/flow-components#2959 Cherry-pick of: vaadin/web-components#3805 * remove obsolete hidden check








Description
Fixes the column group to not synchronize its hidden state to child columns when it is attached, and visible. The change restructures the hidden logic to hopefully be a bit more clearer, and manages to remove one state property for the synchronization, as well as some observers.
Fixes vaadin/flow-components#2959
Type of change