Skip to content

chore: cleanup iron-list-core of grid mode - #3873

Merged
tomivirkki merged 1 commit into
masterfrom
cleanup-iron-list-core
May 18, 2022
Merged

tomivirkki merged 1 commit into
masterfrom
cleanup-iron-list-core

Conversation

@tomivirkki

Copy link
Copy Markdown
Member

Follow up for #321 (comment)

Remove grid mode specific code from iron-list-core.

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan web-padawan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We can also clean up the following code separately:

:host(:not([grid])) #items > ::slotted(*) {
width: 100%;
}

@tomivirkki
tomivirkki merged commit 8cb21c9 into master May 18, 2022
@tomivirkki
tomivirkki deleted the cleanup-iron-list-core branch May 18, 2022 12:05
@yuriy-fix yuriy-fix added the BFP Bug fix prioritised by a customer label May 19, 2022
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 23.1.0.rc1 and is also targeting the upcoming stable 23.1.0 version.

@yuriy-fix yuriy-fix removed the BFP Bug fix prioritised by a customer label Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants