Skip to content

fix: call stopPropagation() when clearing on Esc - #3883

Merged
web-padawan merged 1 commit into
masterfrom
fix/esc-clear-stop-propagation
May 19, 2022
Merged

web-padawan merged 1 commit into
masterfrom
fix/esc-clear-stop-propagation

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

See #3872 (comment)

Note: the vaadin-combo-box that has custom logic for clear button already uses stopPropagation():

} else if (this.clearButtonVisible && !!this.value) {
e.stopPropagation();
// The clear button is visible and the overlay is closed, so clear the value.
this._clear();

Type of change

  • Bugfix

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan
web-padawan merged commit 20c6051 into master May 19, 2022
@web-padawan
web-padawan deleted the fix/esc-clear-stop-propagation branch May 19, 2022 12:50
web-padawan added a commit that referenced this pull request May 19, 2022
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
sissbruecker pushed a commit that referenced this pull request May 19, 2022
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 23.1.0.rc1 and is also targeting the upcoming stable 23.1.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants