Skip to content

test: move components integration tests to own package - #3896

Merged
web-padawan merged 6 commits into
masterfrom
test/integration
May 20, 2022
Merged

web-padawan merged 6 commits into
masterfrom
test/integration

Conversation

@web-padawan

@web-padawan web-padawan commented May 19, 2022 •

Copy link
Copy Markdown
Member

Description

Fixes #3892

Type of change

  • Internal change / tests

@web-padawan
web-padawan marked this pull request as ready for review May 19, 2022 15:34
Comment thread README.md Resolved
Co-authored-by: Sergey Vinogradov <mr.vursen@gmail.com>
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tomivirkki tomivirkki left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting rid of the unnecessary devDependencies in component packages makes sense, but should the integration tests still run for a PR targeting one of the components used in the ITs? They're not too heavy after all and the parallel run would probably eliminate increases in the total test duration.

@web-padawan

Copy link
Copy Markdown
Member Author

should the integration tests still run for a PR targeting one of the components used in the ITs?

Yes, that's how it already works. We get changed packages and if for example date-picker package (or any of its dependencies) is changed in a PR, the integration-tests package will also be changed, so all the ITs will run.

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 23.1.0.rc1 and is also targeting the upcoming stable 23.1.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Introduce separate workflow for running integration tests

4 participants