Skip to content

refactor: remove obsolete overlay content code - #3901

Merged
web-padawan merged 1 commit into
masterfrom
refactor/obsolete-code
May 20, 2022
Merged

web-padawan merged 1 commit into
masterfrom
refactor/obsolete-code

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

There is a code in the overlay content that accesses the vaadin-date-picker-overlay and sets opened to false.

This is not needed because the following close event will do it by using the _close method:

this._overlayContent.addEventListener('close', this._close.bind(this));

_close(e) {
if (e) {
e.stopPropagation();
}
this._focus();
this.close();
}

Type of change

  • Refactor

@web-padawan
web-padawan requested a review from tomivirkki May 20, 2022 09:09
@web-padawan
web-padawan marked this pull request as ready for review May 20, 2022 09:09
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@web-padawan
web-padawan merged commit b2ad3ca into master May 20, 2022
@web-padawan
web-padawan deleted the refactor/obsolete-code branch May 20, 2022 09:45
web-padawan added a commit that referenced this pull request May 20, 2022
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
web-padawan added a commit that referenced this pull request May 20, 2022
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 23.1.0.rc1 and is also targeting the upcoming stable 23.1.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants