Repository navigation
refactor: remove obsolete overlay content code - #3901
Merged
Merged
Conversation
web-padawan
marked this pull request as ready for review
May 20, 2022 09:09
|
Kudos, SonarCloud Quality Gate passed! |
tomivirkki
approved these changes
May 20, 2022
vaadin-bot
pushed a commit
that referenced
this pull request
May 20, 2022
vaadin-bot
pushed a commit
that referenced
this pull request
May 20, 2022
web-padawan
added a commit
that referenced
this pull request
May 20, 2022
web-padawan
added a commit
that referenced
this pull request
May 20, 2022
Collaborator
|
This ticket/PR has been released with Vaadin 23.1.0.rc1 and is also targeting the upcoming stable 23.1.0 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
There is a code in the overlay content that accesses the
vaadin-date-picker-overlayand setsopenedtofalse.This is not needed because the following
closeevent will do it by using the_closemethod:web-components/packages/date-picker/src/vaadin-date-picker-mixin.js
Line 488 in ddb628d
web-components/packages/date-picker/src/vaadin-date-picker-mixin.js
Lines 572 to 578 in ddb628d
Type of change