Skip to content

fix: remove not relevant user tags when replacing users (#3891) (CP: 23.0) - #3916

Merged
web-padawan merged 2 commits into
23.0from
cp/field-highlighter/set-users
May 24, 2022
Merged

web-padawan merged 2 commits into
23.0from
cp/field-highlighter/set-users

Conversation

@vursen

@vursen vursen commented May 23, 2022 •

Copy link
Copy Markdown
Contributor

Description

This PR is a manual cherry-pick of the following fix to 23.0:

Type of change

  • Bugfix

Checklist

  • I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@vursen
vursen changed the base branch from master to 23.0 May 23, 2022 14:17
if (this.flashing) {
// schedule next flash later
this.push('_flashQueue', tags);
// Schedule next flash later

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: Here was the conflict.

@vursen
vursen requested a review from web-padawan May 23, 2022 14:18
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan
web-padawan merged commit 6e73559 into 23.0 May 24, 2022
@web-padawan
web-padawan deleted the cp/field-highlighter/set-users branch May 24, 2022 09:49
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 23.0.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants