Skip to content

refactor: cleanup multi-select-combo-box logic - #3938

Merged
web-padawan merged 2 commits into
masterfrom
refactor/cleanup-combo-box
May 26, 2022
Merged

web-padawan merged 2 commits into
masterfrom
refactor/cleanup-combo-box

Conversation

@web-padawan

@web-padawan web-padawan commented May 26, 2022 •

Copy link
Copy Markdown
Member

Description

  1. Removed logic responsible for updating overlay width because the vaadin-multi-select-combo-box no longer changes its input width dynamically based on the amount of chips selected (that's how the original addon worked).
  2. Updated to use public requestContentUpdate() instead of accessing scroller. Also, clarified the related comment.
  3. Updated visual tests to change input width before opening, to not rely on the removed behavior (see 1.)

Type of change

  • Refactor

@web-padawan
web-padawan requested a review from vursen May 26, 2022 12:59
@web-padawan
web-padawan marked this pull request as ready for review May 26, 2022 12:59
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 23.1.0.rc2 and is also targeting the upcoming stable 23.1.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants