Repository navigation
refactor: update menu renderer to not use flush - #3951
Merged
Merged
Conversation
web-padawan
force-pushed
the
refactor/init-submenu
branch
from
May 27, 2022 12:10
cb9d6fb to
40856df
Compare
vursen
approved these changes
May 27, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
Collaborator
|
This ticket/PR has been released with Vaadin 23.1.0.rc2 and is also targeting the upcoming stable 23.1.0 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
Updated the logic to not use
flush()as it's not needed: we no longer support ShadyDOM, and there are no debouncers that need to be flushed in case of attaching emptyvaadin-context-menu-list-box(we initialize its items later).Type of change