Skip to content

refactor: update menu renderer to not use flush - #3951

Merged
web-padawan merged 1 commit into
masterfrom
refactor/init-submenu
May 27, 2022
Merged

web-padawan merged 1 commit into
masterfrom
refactor/init-submenu

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

Updated the logic to not use flush() as it's not needed: we no longer support ShadyDOM, and there are no debouncers that need to be flushed in case of attaching empty vaadin-context-menu-list-box (we initialize its items later).

Type of change

  • Refactor

@web-padawan
web-padawan requested a review from vursen May 27, 2022 12:03
@web-padawan
web-padawan force-pushed the refactor/init-submenu branch from cb9d6fb to 40856df Compare May 27, 2022 12:10
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 23.1.0.rc2 and is also targeting the upcoming stable 23.1.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants