Skip to content

test: speed up field highlighter unit tests - #3966

Merged
vursen merged 1 commit into
masterfrom
test/speed-up-field-highlighter-tests
May 30, 2022
Merged

vursen merged 1 commit into
masterfrom
test/speed-up-field-highlighter-tests

Conversation

@vursen

@vursen vursen commented May 30, 2022 •

Copy link
Copy Markdown
Contributor

Description

The PR speeds up field highlighter unit tests by decreasing the delay and duration of the flashing animation.

Before:

yarn run v1.22.18
$ web-test-runner --group field-highlighter

Chrome: |██████████████████████████████| 3/3 test files | 93 passed, 0 failed

Finished running tests in 11.3s, all tests passed! 🎉

✨  Done in 11.78s.

After:

yarn run v1.22.18
$ web-test-runner --group field-highlighter

Chrome: |██████████████████████████████| 3/3 test files | 93 passed, 0 failed

Finished running tests in 1.7s, all tests passed! 🎉

✨  Done in 2.22s.

Type of change

  • Internal

Checklist

  • I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@vursen
vursen requested a review from web-padawan May 30, 2022 12:14
@vursen
vursen marked this pull request as ready for review May 30, 2022 12:14
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vursen
vursen merged commit 03d5679 into master May 30, 2022
@vursen
vursen deleted the test/speed-up-field-highlighter-tests branch May 30, 2022 12:34
@vaadin-bot

Copy link
Copy Markdown
Collaborator

Hi @vursen , this commit cannot be picked to 23.0 by this bot, can you take a look and pick it manually?
Error Message: Error: Command failed: git cherry-pick 03d5679
error: could not apply 03d5679... test: speed up field highlighter tests (#3966)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 23.1.0.rc2 and is also targeting the upcoming stable 23.1.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants