Repository navigation
fix: keep input value when data provider resolves callback - #3971
Merged
Merged
Conversation
Member
Author
|
Maybe we should also add a regression test, however the component currently doesn't have any lazy loading tests. |
|
Kudos, SonarCloud Quality Gate passed!
|
web-padawan
approved these changes
May 30, 2022
web-padawan
left a comment
Member
There was a problem hiding this comment.
LGTM. Ideally, we should replace checks for focused attribute with something like this:
web-components/packages/component-base/src/focus-utils.js
Lines 206 to 208 in 87926bd
I will create a separate issue to not block this PR.
Collaborator
|
This ticket/PR has been released with Vaadin 23.1.0.rc2 and is also targeting the upcoming stable 23.1.0 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
Prevent data provider mixin from clearing the input value when the data provider callback resolves. The data provider mixin relies on the
focusedattribute being present on the combo box to determine whether the component is actively used, however thefocusedattribute is never set on the internal combo box. This change propagates thefocusedattribute to the internal combo box to fix that.Fixes #3969
Type of change