Skip to content

refactor: make components and mixins use unique id utilities - #3994

Merged
web-padawan merged 4 commits into
masterfrom
refactor/use-unique-id-utils
Jun 8, 2022
Merged

web-padawan merged 4 commits into
masterfrom
refactor/use-unique-id-utils

Conversation

@vursen

@vursen vursen commented Jun 3, 2022 •

Copy link
Copy Markdown
Contributor

Description

The PR makes the components and mixins use the utilities for generating unique ids recently added in #3993.

Type of change

  • Internal

Checklist

  • I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@vursen vursen changed the title refactor: make components and mixins use unique-id-utils refactor: make components and mixins use unique id utilities Jun 3, 2022
@vursen
vursen changed the base branch from master to feat/unique-id-utils June 3, 2022 14:42
@vursen
vursen changed the base branch from feat/unique-id-utils to master June 3, 2022 14:42
@vursen
vursen marked this pull request as ready for review June 7, 2022 09:20
@vursen
vursen requested a review from web-padawan June 7, 2022 09:20
@vursen
vursen force-pushed the refactor/use-unique-id-utils branch from f4ddaa8 to b34fe84 Compare June 8, 2022 07:01

@web-padawan web-padawan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like resetUniqueId() is not used in some snapshot tests modified in this PR:

  • checkbox
  • checkbox-group
  • crud
  • radio-group

@vursen

vursen commented Jun 8, 2022

Copy link
Copy Markdown
Contributor Author

Looks like resetUniqueId() is not used in some snapshot tests modified in this PR:

Thanks, added.

@sonarqubecloud

sonarqubecloud Bot commented Jun 8, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan
web-padawan merged commit faec584 into master Jun 8, 2022
@web-padawan
web-padawan deleted the refactor/use-unique-id-utils branch June 8, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants