Repository navigation
fix: make getEventContext() work with context-menu on iOS - #4004
Merged
Merged
Conversation
tomivirkki
reviewed
Jun 7, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
tomivirkki
approved these changes
Jun 8, 2022
Collaborator
|
Hi @web-padawan , this commit cannot be picked to 22.0 by this bot, can you take a look and pick it manually? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
This PR addresses a problem that makes
grid.getEventContext()broken when usingvaadin-contextmenuevent.Note, this logic is quite fundamental for
vaadin-gridcontext-menu feature, as you can see it's used in two places:The actual problem is that
event.composedPath()returns[](empty array) as soon as you usesetTimeout().This is exactly what we are doing for
touchstartevent by setting timer in ourcontextmenugesture.Fixes vaadin/flow-components#3296
Fixes vaadin/flow-components#2951
Note: this needs an integration test, I'd like to add it in a separate PR to make cherry-picking easier.
Also note, the unit test that I added covers
contextmenuevent and nottouchstart.We do not currently run tests on iOS, so corresponding test suite is skipped 😕
Type of change